fix: using te and fsdp leads to multiple device found error#1453
Merged
t-vi merged 1 commit intoLightning-AI:mainfrom Nov 19, 2024
Merged
fix: using te and fsdp leads to multiple device found error#1453t-vi merged 1 commit intoLightning-AI:mainfrom
t-vi merged 1 commit intoLightning-AI:mainfrom
Conversation
kshitij12345
commented
Nov 19, 2024
kshitij12345
changed the title
kshitij12345
requested review from
lantiga,
mruberry and
t-vi
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the error below:
As reported by Mixology team,
NVFUSER_DISABLE=multidevice torchrun --standalone --max-restarts=0 --no-python --nproc-per-node=8 python /opt/pytorch/lightning-thunder/thunder/benchmarks/benchmark_litgpt.py --model_name Llama-3-8B --distributed_mode fsdp --shard_mode zero2 --compile inductor --checkpoint_activations False --low_precision_mode fp8-delayed-te --micro_batch_size 1 --bucketing_mode blockwe see the error